Feature/interface signaller UI #1076

lukasrad02 · 2025-05-20T08:43:09Z

This PR adds a new modal that allows interface signallers to interact with the software

PR Checklist

Please make sure to fulfil the following conditions before marking this PR ready for review:

If this PR adds or changes features or fixes bugs, this has been added to the changelog
If this PR adds new actions or other ways to alter the state, test scenarios have been added.
I have the right to license the code submitted with this Pull Request under the mentioned license in the file LICENSE-README.md (i.e., this is my
own code or code licensed under a license compatible to AGPL v3.0 or later, for exceptions look into LICENSE-README.md) and
hereby license the code in this Pull Request under it.
I certify that by signing off my commits (see In case of using third party code, I have given appropriate credit.
We are using DCO for that, see here for more information.
If I have used third party code and I mentioned it in the code, I also updated the inspired-by-or-copied-from-list.html list to include the links.

Signed-off-by: Lukas Radermacher <[email protected]>

ClFeSc

As discussed, my review as far as I've gotten today.

CHANGELOG.md

...hared/simulation-event-based-report-editor/simulation-event-based-report-editor.component.ts

...exercises/exercise/shared/simulation/signaller-modal/details-modal/eoc-information/README.md

...dal/details-modal/signaller-modal-details-modal/signaller-modal-details-modal.component.html

...l/signaller-modal-recurring-report-modal/signaller-modal-recurring-report-modal.component.ts

ClFeSc · 2025-07-15T14:56:01Z

...signaller-modal/signaller-modal-region-commands/signaller-modal-region-commands.component.ts

+            requiredBehaviors: ['transferBehavior'],
+            errorMessage: 'Dieser Bereich kann keine Fahrzeuge bereitstellen',
+        },
+        // TODO: Radio channels


TODO for this PR?

...signaller-modal/signaller-modal-region-commands/signaller-modal-region-commands.component.ts

...ler-modal/signaller-modal-region-information/signaller-modal-region-information.component.ts

ClFeSc · 2025-07-15T15:18:45Z

...ler-modal/signaller-modal-region-information/signaller-modal-region-information.component.ts

+            errorMessage: 'Dieser Bereich behandelt keine Patienten',
+            loading$: new BehaviorSubject<boolean>(false),
+        },
+        // TODO: Location


TODO for this PR? Also for the two TODOs below.

...ation/signaller-modal/signaller-modal-interactions/signaller-modal-interactions.component.ts

Co-authored-by: Clemens <[email protected]> Signed-off-by: Lukas Radermacher <[email protected]>

Signed-off-by: Lukas Radermacher <[email protected]>

ClFeSc · 2025-07-22T15:40:28Z

...art-transfer-of-category-modal/signaller-modal-start-transfer-of-category-modal.component.ts

-        // Otherwise, it might become 0 in between, if the first action is handled faster than the second one is proposed
+        // loadingCount has to be fully increased before actually proposing the first action. Otherwise, it could become 0 in between.
+        // Hence, all actions to be proposed are collected here and proposed in the end.
+        // const actionProposers: (() => void)[] = [];


Remove this line, it seems to be a leftover from before importing ExerciseAction.

...hared/simulation-event-based-report-editor/simulation-event-based-report-editor.component.ts

...art-transfer-of-category-modal/signaller-modal-start-transfer-of-category-modal.component.ts

ClFeSc · 2025-07-22T15:46:12Z

...r-modal-transfer-connections-editor/signaller-modal-transfer-connections-editor.component.ts

+                    )
+                    .map(([id, transferPoint]) => ({
+                        key: id,
+                        name: TransferPoint.getFullName(transferPoint),


I would opt for the second option: Returning the internal name only if the transfer point is not in a simulated region. If it is the parenthesis are causing more confusion than relaxing the trainers in the thought of "This is a transfer point, so it has an internal name.", as you're never able to see the transfer point itself, as far as I know.

...ation/signaller-modal/signaller-modal-interactions/signaller-modal-interactions.component.ts

...signaller-modal/signaller-modal-region-commands/signaller-modal-region-commands.component.ts

...ler-modal/signaller-modal-region-information/signaller-modal-region-information.component.ts

lukasrad02 added 30 commits May 20, 2025 10:40

Add signaller modal

96eb4bd

Signed-off-by: Lukas Radermacher <[email protected]>

WIP

9cfabf9

Signed-off-by: Lukas Radermacher <[email protected]>

Add working layer system

0b7d2ec

Signed-off-by: Lukas Radermacher <[email protected]>

Detect hotkey collisions case insensitively

bd68667

Signed-off-by: Lukas Radermacher <[email protected]>

Add hotkey indicator

b9ad151

Signed-off-by: Lukas Radermacher <[email protected]>

Add hotkey indicator to shared module

c4fa656

Signed-off-by: Lukas Radermacher <[email protected]>

Use replay subject to detect state in indicator

032bf98

Signed-off-by: Lukas Radermacher <[email protected]>

Implement region selection

b89dd6b

Signed-off-by: Lukas Radermacher <[email protected]>

Scroll to selected region

a818017

Signed-off-by: Lukas Radermacher <[email protected]>

Allow removing hotkeys by hotkey instance

e41e6fe

Signed-off-by: Lukas Radermacher <[email protected]>

Add hotkey for radiograms and auto-select region

358fb3b

Signed-off-by: Lukas Radermacher <[email protected]>

Add component for region overview

4f5652d

Signed-off-by: Lukas Radermacher <[email protected]>

Reset selected region when it is deleted

5340c9c

Signed-off-by: Lukas Radermacher <[email protected]>

Show current leader

0148616

Signed-off-by: Lukas Radermacher <[email protected]>

Use hotkeys service in searchable dropdown

db0b501

Signed-off-by: Lukas Radermacher <[email protected]>

Show info+command columns or warning without leader

a4fa149

Signed-off-by: Lukas Radermacher <[email protected]>

Size columns evenly

c8d1365

Signed-off-by: Lukas Radermacher <[email protected]>

WIP: Allow requesting information

c88a821

Signed-off-by: Lukas Radermacher <[email protected]>

Run prettier

c84495b

Signed-off-by: Lukas Radermacher <[email protected]>

Add keys to radiograms

7217295

Signed-off-by: Lukas Radermacher <[email protected]>

Add UI to query information

d0a7879

Signed-off-by: Lukas Radermacher <[email protected]>

Add personnel count to requestable information

fc4d700

Signed-off-by: Lukas Radermacher <[email protected]>

Add transfer connections to requestable information

79071b5

Signed-off-by: Lukas Radermacher <[email protected]>

Remove unnecessary initializers and assertions

e88cdb3

Signed-off-by: Lukas Radermacher <[email protected]>

Add required resources to requestable information

c01bf64

Signed-off-by: Lukas Radermacher <[email protected]>

Show 0 for not required resources

d9598ad

Signed-off-by: Lukas Radermacher <[email protected]>

Remove finished todo comment

02977e0

Signed-off-by: Lukas Radermacher <[email protected]>

Refactor information requests

063e51c

Signed-off-by: Lukas Radermacher <[email protected]>

Fix some details after the refactoring

20048f0

Signed-off-by: Lukas Radermacher <[email protected]>

Remove comma after interaction name

54fb005

Signed-off-by: Lukas Radermacher <[email protected]>

lukasrad02 added 11 commits June 2, 2025 10:45

Add missing hotkey

ac0f9e2

Signed-off-by: Lukas Radermacher <[email protected]>

Adhere to naming convention

343695f

Signed-off-by: Lukas Radermacher <[email protected]>

Consistent variable naming

de38327

Signed-off-by: Lukas Radermacher <[email protected]>

Remove all hotkey layers on destroy

725d48a

Signed-off-by: Lukas Radermacher <[email protected]>

Fix NG0100 in hotkey indicator

f6ea4ad

Signed-off-by: Lukas Radermacher <[email protected]>

Add missing autoClose attribute

7163fdc

Signed-off-by: Lukas Radermacher <[email protected]>

Remove unused import, fix TS error

97dcc6a

Signed-off-by: Lukas Radermacher <[email protected]>

Remove hotkey, restore previous layout

3c49bd8

Signed-off-by: Lukas Radermacher <[email protected]>

Allo use of tabindex attribute

c439f7f

Signed-off-by: Lukas Radermacher <[email protected]>

Distinguish keys on radiograms

2623a06

Signed-off-by: Lukas Radermacher <[email protected]>

Merge branch 'dev' into feature/interface-signaller-ui

fbd0e58

Signed-off-by: Lukas Radermacher <[email protected]>

lukasrad02 mentioned this pull request Jul 9, 2025

Add test scenarios for IFS UI changes hpi-sam/digital-fuesim-manv-public-test-scenarios#17

Open

1 task

Add IFS UI to changelog

104c9c8

Signed-off-by: Lukas Radermacher <[email protected]>

lukasrad02 marked this pull request as ready for review July 9, 2025 11:39

ClFeSc requested changes Jul 15, 2025

View reviewed changes

lukasrad02 and others added 11 commits July 15, 2025 20:09

Fix typo in changelog

8375922

Co-authored-by: Clemens <[email protected]> Signed-off-by: Lukas Radermacher <[email protected]>

Fix type assertion

255fcd5

Signed-off-by: Lukas Radermacher <[email protected]>

Hide hotkeys in details modal if they're not used

9b8e6cd

Signed-off-by: Lukas Radermacher <[email protected]>

Add unit to interval variables

24d684f

Signed-off-by: Lukas Radermacher <[email protected]>

Add padding after label

7639167

Signed-off-by: Lukas Radermacher <[email protected]>

Add type constraint

544ddec

Signed-off-by: Lukas Radermacher <[email protected]>

Correctly handle errors from both actions

ada2e29

Signed-off-by: Lukas Radermacher <[email protected]>

Use more appropriate, domain-specific wording

69ceb28

Signed-off-by: Lukas Radermacher <[email protected]>

Make hotkey callback parameters optional

76f8912

Signed-off-by: Lukas Radermacher <[email protected]>

Simplify and explain condition

1d63b5c

Signed-off-by: Lukas Radermacher <[email protected]>

Support multiple, whitespace-separated filters

9b6fa4d

Signed-off-by: Lukas Radermacher <[email protected]>

lukasrad02 mentioned this pull request Jul 16, 2025

Allow EOC to send radiograms #1093

Open

Remove todo (moved to hpi-sam#1093)

2e497a8

Signed-off-by: Lukas Radermacher <[email protected]>

lukasrad02 mentioned this pull request Jul 16, 2025

Selector can return undefined despite its type definition #1095

Open

ClFeSc reviewed Jul 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/interface signaller UI #1076

Feature/interface signaller UI #1076

Uh oh!

lukasrad02 commented May 20, 2025 •

edited

Loading

Uh oh!

ClFeSc left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ClFeSc Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!

ClFeSc Jul 15, 2025

Uh oh!

Uh oh!

ClFeSc Jul 22, 2025

Uh oh!

Uh oh!

Uh oh!

ClFeSc Jul 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Feature/interface signaller UI #1076

Are you sure you want to change the base?

Feature/interface signaller UI #1076

Uh oh!

Conversation

lukasrad02 commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Uh oh!

ClFeSc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ClFeSc Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ClFeSc Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ClFeSc Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ClFeSc Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukasrad02 commented May 20, 2025 •

edited

Loading